Why and what for is limit of parameters in subroutine ?

When I wrote the code, it seemed like it should be more than enough.
Remember, that there is also a maximum line length (is it 256 characters?).

I suggest that if you need more parameters, that you instead just use
global named variables. That should be functionally equivalent for
almost all cases. (I assume that these procedures are not being called
recursively).

It is possible to increase the limit (probably by changing a single
constant in an include file). Removing the limit would require more work
and would have little benefit.

Regards,

Ken

Post by tuxcnc
Hi.
Subroutine can get up to 30 parameters.
Why and what for is the limit?
My friend makes an large ngcgui procedure and lacks parameters.
I cant help him with no changes source code of LinuxCNC.
Is it possible increase or remove the limit?
Regards.
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Emc-developers mailing list
https://lists.sourceforge.net/lists/listinfo/emc-developers

tuxcnc

2012-11-26 21:53:02 UTC

Thanks for your answer.

The procedure is for lathe.
Most of parameters are one digit only, for example 1 is taper, 2 is
sphere, etc.
There are many parameters of this type, and 30 is not enought.
You are right, removing the limit would require more work
and would have little benefit.
But increase the limit is no dangerous.
You can get "Command too long" error, with limit of 30 paremeters .
Of course more than 50 have no sense.
Only a few lines needs changes to increase limit in ngcgui.
I done it, I get more parameter windows, but of course not works with
more than 30 parameters .

Is it possible to increase the limit to 50 parameters and change the
source of LinuxCNC in git ?

Regards.

andy pugh

2012-11-26 22:02:51 UTC

Post by tuxcnc
The procedure is for lathe.
Most of parameters are one digit only, for example 1 is taper, 2 is
sphere, etc.
There are many parameters of this type, and 30 is not enought.

What are you trying to do? I feel that running out of parameters is
probably a sign that you are going about things the wrong way.

--
atp
If you can't fix it, you don't own it.
http://www.ifixit.com/Manifesto

Z. Maciej "Miki" Bajkowski

2012-11-27 11:00:03 UTC

Hello
Sorry, my English is poor. I wrote a subroutine NGCGUI, lathe supports
the G-code commands G1, G2, G3, in all possible combinations: od, in,
taper-od, taper-in, concave and convex hemisphere. Subroutine an option
to perform any operation on the diameter of the final derivative. This
reduces the number of necessary subroutine in half.

Adding operations on the initial diameter of the derivative will reduce
the number of subroutine caused by a further 50%. I need it more than 30
variables in the subroutine.
Most of these variables is optionally used as needed, and contains only
one digit representing the choice of a particular option.
Subroutine disadvantage is that it is not intuitive to use. But that is
the price for the unlimited ability to generate tool paths.

Regards

Miki

John Thornton

2012-11-27 11:31:44 UTC

I feel as though your trying to write a complete program using
subroutines but have not discovered ngcgui which allows you to do so and
not need more that 10 variables per sub usually.

John

Kenneth Lerman

2012-11-27 19:25:25 UTC

A cleaner solution would be to change ngcgui to support parameters that
are implemented as global named parameters.

Ken

Post by John Thornton
I feel as though your trying to write a complete program using
subroutines but have not discovered ngcgui which allows you to do so and
not need more that 10 variables per sub usually.
John

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Emc-developers mailing list
https://lists.sourceforge.net/lists/listinfo/emc-developers

Z. Maciej "Miki" Bajkowski

2012-11-27 13:17:03 UTC

Post by John Thornton
I feel as though your trying to write a complete program using
subroutines but have not discovered ngcgui which allows you to do so >and
not need more that 10 variables per sub usually.

John Thornton

2012-11-27 14:33:02 UTC

I guess I have no clue what your doing... I have dozens of subs and
ngcgui concatenates them all together into one file rather nicely. For
each op I just fill in the few variables and tell ngcgui to create it
and when I'm done with all the ops I tell ngcgui to generate the code...
the total code can have hundreds of variables with no problem at all.

John

Dear John
Turning is done on the basis of the figure, which contains only the
basic dimensions. Try to embed taper to taper, or hemisphere of the
taper so that the fault was not.
Therefore aggregates in one subroutine for successive operations of the
same diameter.
I need to freely choose the tool. Fedrate determine initial and final.
Virtually everything that occurs in the subroutine code, needs to be set
manually for this particular subroutine.
I have 10 tools that I can use - I do 10 subroutine, only to find the tool?
To do what I can in five subroutine, you would have to write dozens of them.
Regards
Miki
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Emc-developers mailing list
https://lists.sourceforge.net/lists/listinfo/emc-developers

Z. Maciej "Miki" Bajkowski

2012-11-27 15:34:44 UTC

Post by John Thornton
I guess I have no clue what your doing... I have dozens of subs and
ngcgui concatenates them all together into one file rather nicely. For
each op I just fill in the few variables and tell ngcgui to create it
and when I'm done with all the ops I tell ngcgui to generate the code...
the total code can have hundreds of variables with no problem at all.

Dear John

NGCGUI can not associate with each other subroutines. Therefore, in a
subroutine bind two. I would like to combine three.

I'm working on a lathe, and I use your subroutine every day. We add to
it what I needed.

I am a programmer, PHP, NGCGUI. Python can not.

That is why I am writing this in NGCGUI.

And I ask for an increase in the available variables to 50

Regards

Miki

John Thornton

2012-11-27 16:08:06 UTC

I wish I understood what you said... can you give me an example or
something to help me understand what your trying to do?

John

Post by Z. Maciej "Miki" Bajkowski
NGCGUI can not associate with each other subroutines. Therefore, in a
subroutine bind two. I would like to combine three. I'm working on a
lathe,

Z. Maciej "Miki" Bajkowski

2012-11-27 16:35:11 UTC

Post by John Thornton
I wish I understood what you said... can you give me an example or
something to help me understand what your trying to do?

Dear John

Loading Image...

The shape of the three sub-procedures programm, each time using the same
subroutine.

Pay attention to the connection point taper and hemisphere. You have to
calculate in one procedure. How do two subroutines, you have to use a
calculator.

Regards

Miki

andy pugh

2012-11-27 17:12:54 UTC

Post by Z. Maciej "Miki" Bajkowski
http://www.cnc.info.pl/pics/f5566797a29d.png

http://www.linuxcnc.org/index.php/forum/40-subroutines-and-ngcgui/11414-metric-lathe-subroutines-g71-g72-etc-etc?lang=english#11414

Might do what you want.
(I think that allows you to define a profile with G1 G2 and G3 moves,
then puts in the required cuts to make them, a typical G71)

Somewhere I have seen another approach to adding G71 / G72 to
LinuxCNC, but I can't currently find it.

--
atp
If you can't fix it, you don't own it.
http://www.ifixit.com/Manifesto

Z. Maciej "Miki" Bajkowski

2012-11-27 17:41:43 UTC

Post by andy pugh
http://www.linuxcnc.org/index.php/forum/40-subroutines-and-ngcgui/11414-metric-lathe-subroutines-g71-g72-etc-etc?lang=english#11414
Might do what you want.
(I think that allows you to define a profile with G1 G2 and G3 moves,
then puts in the required cuts to make them, a typical G71)
Somewhere I have seen another approach to adding G71 / G72 to
LinuxCNC, but I can't currently find it.

andy pugh

2012-11-27 18:17:16 UTC

Post by Z. Maciej "Miki" Bajkowski
Do you think that simply do something with 40 subroutine than one?

I think that it might be, as they fit together into a system that (I
believe) lets you program an arbitrary profile.
However, I have not used that setup, so I don't know how it works.

If you change / src / emc / rs274ngc / interp_internal.hh line224
then you can have as many parameters as you like. There may be
consequences.

--
atp
If you can't fix it, you don't own it.
http://www.ifixit.com/Manifesto

Z. Maciej "Miki" Bajkowski

2012-11-27 18:55:18 UTC

Post by andy pugh
I think that it might be, as they fit together into a system that (I
believe) lets you program an arbitrary profile.
However, I have not used that setup, so I don't know how it works.
If you change / src / emc / rs274ngc / interp_internal.hh line224
then you can have as many parameters as you like. There may be
consequences.

Thank you, I will try and will inform about the consequences.

Regards

Miki

Kenneth Lerman

2012-11-27 19:24:00 UTC

Post by andy pugh

Post by Z. Maciej "Miki" Bajkowski
Do you think that simply do something with 40 subroutine than one?

I think that it might be, as they fit together into a system that (I
believe) lets you program an arbitrary profile.
However, I have not used that setup, so I don't know how it works.
If you change / src / emc / rs274ngc / interp_internal.hh line224
then you can have as many parameters as you like. There may be
consequences.

If the guy who wrote the code (that would be me) did it right,
everything should work fine. There would only be an issue if some code
tried to access parameter #31 expecting it to be a normal parameter.

For that reason, I would not recommend porting this back to the mainline
code.

Ken

Z. Maciej "Miki" Bajkowski

2012-11-27 20:00:37 UTC

Post by andy pugh
If you change / src / emc / rs274ngc / interp_internal.hh line224
then you can have as many parameters as you like. There may be
consequences.

Dear Andy

Loading Image...

line 224: # define G_97 970 - did not change

line 240: # define INTERP_SUB_PARAMS 30

I changed the # define INTERP_SUB_PARAMS 50

Interp_internal.hh file in two places, improved in both.

I still have the message "Too many variables in"

Regards

P.S. LinuxCNC GIT version.

Kent A. Reed

2012-11-27 20:45:45 UTC

Post by andy pugh
If you change / src / emc / rs274ngc / interp_internal.hh line224
then you can have as many parameters as you like. There may be
consequences.

Dear Andy
http://www.cnc.info.pl/pics/1b57b2f91a55.png
line 224: # define G_97 970 - did not change
line 240: # define INTERP_SUB_PARAMS 30
I changed the # define INTERP_SUB_PARAMS 50
Interp_internal.hh file in two places, improved in both.
I still have the message "Too many variables in"
Regards
P.S. LinuxCNC GIT version.

Hi, Miki.

I am not an expert in the internals, but I just did a little digging
through the source code with my favorite tool "grep".

The English-language version of the error message you are receiving is
"Too many subroutine parameters". So far as I can determine, this
message is thrown from only one place, a CHKS function in the source
code src/emc/rs274ngc/interp_read.cc, and it is thrown only if param_cnt

Post by Z. Maciej "Miki" Bajkowski
= INTERP_SUB_PARAMS

This leaves several possibilities

1) param_cnt is reaching 50

or

2) interp_read.cc didn't get recompiled after you changed the defined
value of INTERP_SUB_PARAMS to be 50

or

3) ??

Good luck.

Regards,
Kent

andy pugh

2012-11-27 20:47:37 UTC

Post by Z. Maciej "Miki" Bajkowski
I changed the # define INTERP_SUB_PARAMS 50

Changing the right line for the version you have does seem best.

Post by Z. Maciej "Miki" Bajkowski
Interp_internal.hh file in two places, improved in both.
I still have the message "Too many variables in"

That is NCE_TOO_MANY_SUBROUTINE_PARAMETERS (having untranslated the
Polish) which is only raised in one place,
interp_read.cc (around line 1648 in the version I am looking at) and
that uses the #define value.

I am assuming that you recompiled?

--
atp
If you can't fix it, you don't own it.
http://www.ifixit.com/Manifesto

Z. Maciej "Miki" Bajkowski

2012-11-27 21:54:24 UTC

Post by andy pugh
I am assuming that you recompiled?

I do not recompile LinuxCNC ... thank you

Regards

Miki

Z. Maciej "Miki" Bajkowski

2012-11-27 23:53:09 UTC

Loading Image...

After recompiling LinuxCNC 40 variables in the subroutine NGCGUI working
properly. Specifically I wrote a lot of numbers. Normally part of about
10 positions.

Thank you all.

Regards

Miki

Z. Maciej "Miki" Bajkowski

2012-11-28 10:38:16 UTC

NGCGUI allows you to create a complex of several subroutines operations.
You can save it to a file by pressing Ctrl-S and do it repeatedly.
LinuxCNC to edit it when you should file a record of the procedure
NGCGUI automatically create tabs filled with data from the file memorized.

Regards

Miki

Z. Maciej "Miki" Bajkowski

2012-12-17 05:34:51 UTC

Hello

Loading Image...

http://www.youtube.com/watch?feature=player_embedded&v=h1EPLOpD_Kg

The picture shows a detail of what I want to bring my lathe using
subroutines NGCGUI.

This can be done in four tabs, the problem is the lack of visualization
tools crossings between tabs.

I can indeed improve the subroutine it, but I have to do this for test
run it, and then I see a collision.

Question: Is it possible to access tools to visualize where you are, to
the material?

Regards

Miki

Z. Maciej "Miki" Bajkowski

2012-11-29 10:09:32 UTC

Hello

As promised to announce that NGCGUI the possibility of a greater number
of variables working properly. I set the value of

/ / Subroutine parameters
# define INTERP_SUB_PARAMS 30
# define INTERP_SUB_ROUTINE_LEVELS 10
# define INTERP_FIRST_SUBROUTINE_PARAM 1

/ / Max number of local variables saved (?)
# define MAX_NAMED_PARAMETERS 60

as follows

/ / Subroutine parameters
# define INTERP_SUB_PARAMS 60
# define INTERP_SUB_ROUTINE_LEVELS 10
# define INTERP_FIRST_SUBROUTINE_PARAM 1

/ / Max number of local variables saved (?)
# define MAX_NAMED_PARAMETERS 120

I wrote a large number of random numbers in the form subroutines.
Subroutine did not report an error, and even tried to do something.

Loading Image...

I'll try to show you what she can

Loading Image...

This is the form subroutines. You can create it, but it will not do
anything until it enters the data.

Let's start with the operation face - I think it's called what I called
"Planowanie czoła". Sorry, my Englisch is poor.
Screenshots reveal more.

Loading Image...

I entered 3 values . Procedure face always ends on the Z axis zero
Typing 6 in the first window gave scope for the Z axis from 6mm to 0

Filled in two successive fields with initial diameter of 20 mm and a
final diameter of 20 mm. Informed in this way, a subroutine that is not
cylindrical or conical roll.

I changed the value of the final diameter of 10 mm. I gave the value of
the end point on the axis of -10 mm.

Loading Image...

Subroutine performs 'od'. Need to improve the departure from the
material in the X axis.

http://www.cnc.info.pl/pics/dae8a68ee991.png

Loading Image...

Altering the initial diameter smaller than the final diameter.
Subroutine does "in".

Loading Image...

Automatically disabled face surgery.

We return to the "od" and add the taper on the diameter of the final

Loading Image...

Add radius, and we have a hemisphere.

Loading Image...

Select "1" concavity

Loading Image...

Changing the starting position on the Z axis at -10 mm, the end position
on the Z axis to -5 mm and select the tool number 1

We are in from left to right. Face off automatically.

Loading Image...

Writing this subroutine will take me some time. Presented here, maybe
1/4 of its current capabilities.
Reach them even 3 times as much.

NGCGUI allows you to create a complex of several subroutines operations.
You can save it to a file by pressing Ctrl-S and do it repeatedly.
LinuxCNC to edit it when you should file a record of the procedure
NGCGUI automatically create tabs filled with data from the file
memorized. Are you planning to enter the import of data from a file to
NGCGUI?

Regards

Miki

andy pugh

2012-11-29 10:38:29 UTC

Are you planning to enter the import of data from a file to NGCGUI?

You are almost creating a new lathe programming language here. It is a
little difficult to understand what is going on as I can't read
Polish.

I wonder if it might not be simpler at the interface level to define a
series of points and radii in a table? (rather as G71 does on controls
that support it)
However, if you have it working, and it does what you want, you might
as well carry on.

--
atp
If you can't fix it, you don't own it.
http://www.ifixit.com/Manifesto

Z. Maciej "Miki" Bajkowski

2012-11-29 11:04:06 UTC

Post by andy pugh

Are you planning to enter the import of data from a file to NGCGUI?

You are almost creating a new lathe programming language here. It is a
little difficult to understand what is going on as I can't read
Polish.
I wonder if it might not be simpler at the interface level to define a
series of points and radii in a table? (rather as G71 does on controls
that support it)
However, if you have it working, and it does what you want, you might
as well carry on.

Dear Andy

I only use what you have written. I read quite fluent in English. I do
not speak and do not write in English. I use Google translator to
correspond with you.

Turning is done in stages, you need to change tools. Technical drawings
detail the dimensions. It is easier to piece together the final detail
of subroutines rather than enter the coordinates of several points.
In programming, a subroutine can use 5 different tools, changing it once
in the podprocedurze.

If there was the possibility of programming the path in WYSIWYG mode, it
would be to use points.

I miss the import of the NGCGUI operation of multiple subroutines. I can
save myself, and frequently used, but I can not edit.

Regards

Miki

Anders Wallin

2012-11-29 11:28:40 UTC

Post by Z. Maciej "Miki" Bajkowski
Turning is done in stages, you need to change tools. Technical drawings
detail the dimensions. It is easier to piece together the final detail
of subroutines rather than enter the coordinates of several points.
In programming, a subroutine can use 5 different tools, changing it once
in the podprocedurze.

Have you considered using python?
AXIS can use python as a 'filter', i.e. you open the python file from AXIS,
the python file runs and produces G-code, and the G-code appears ready to
run in AXIS.
I have a few examples over here:
https://github.com/aewallin/linuxcnc-scripts
there are images here
https://github.com/aewallin/linuxcnc-scripts/tree/master/gallery

with this approach the program can be made arbitrarily complex, and as you
see my python scripts also use external C++ libraries.

AW

Z. Maciej "Miki" Bajkowski

2012-11-29 13:58:07 UTC

Post by Anders Wallin

Have you considered using python?
AXIS can use python as a 'filter', i.e. you open the python file from AXIS,
the python file runs and produces G-code, and the G-code appears ready to
run in AXIS.
https://github.com/aewallin/linuxcnc-scripts
there are images here
https://github.com/aewallin/linuxcnc-scripts/tree/master/gallery
with this approach the program can be made arbitrarily complex, and as you
see my python scripts also use external C++ libraries.

Dear Anders

Of course, this can be written in Python. But I do not write it. That's
why I use NGCGUI, which features nearly enough for me.
If my idea you like, rewrite it in Python. Code publish up to date on the

http://www.cnc.info.pl/topics54/ngcgui-toczenie-mocno-rozbudowana-procedura-vt40747.htm

If you are interested we call variables and translate their descriptions
into English. Of course, this will require amendments.

Regards

Miki

Z. Maciej "Miki" Bajkowski

2012-11-29 11:31:08 UTC

This post might be inappropriate. Click to display it.

John Thornton

2012-11-27 21:08:30 UTC

That's pretty impressive even if I can't read it.

I don't understand why your not using a filter program which would not
have the limitations your hitting with ngcgui as you would not need to
pass any parameters just plain old G code.

John

Dear Andy
Do you think that simply do something with 40 subroutine than one?
And so I have to share the processing stages. My subroutine combines
logical cylinder or cone of processing the final diameter (concave
hemisphere, the hemisphere convex, taper) starting at the starting point
on the axis Z.
I wish I could do the same for the initial diameter of the end point on
the Z axis
The procedure is here, together with examples of applications.
http://www.cnc.info.pl/topics54/ngcgui-toczenie-mocno-rozbudowana-procedura-vt40747.htm
Regards
Miki
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Emc-developers mailing list
https://lists.sourceforge.net/lists/listinfo/emc-developers

John Thornton

2012-11-27 17:48:04 UTC

Thanks for the screen shot I understand much better what your goal is.
Can you put up a screen shot of the ngcgui page?

Are you trying to program in the path with variables or using a file to
load the path? I assume you have looked at how the helper subroutines
work with the DB25 example. I created a simple subroutine that loads a
path from a file and does simple offsets, something like that might be
used to do your roughing cycle without programming in the path.

http://gnipsel.com/shop/hardinge/files/profilerad.ngc.txt

John